Add grant/revoke schema privileges methods to hive metadata

trinodb · Jul 8, 2021 · 8b2dabd · 8b2dabd
1 parent cdbf453
commit 8b2dabd
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
@@ -2702,6 +2702,18 @@ public Set<String> listEnabledRoles(ConnectorSession session)
         return accessControlMetadata.listEnabledRoles(session);
     }
 
+    @Override
+    public void grantSchemaPrivileges(ConnectorSession session, String schemaName, Set<Privilege> privileges, TrinoPrincipal grantee, boolean grantOption)
+    {
+        accessControlMetadata.grantSchemaPrivileges(session, schemaName, privileges, HivePrincipal.from(grantee), grantOption);
+    }
+
+    @Override
+    public void revokeSchemaPrivileges(ConnectorSession session, String schemaName, Set<Privilege> privileges, TrinoPrincipal grantee, boolean grantOption)
+    {
+        accessControlMetadata.revokeSchemaPrivileges(session, schemaName, privileges, HivePrincipal.from(grantee), grantOption);
+    }
+
     @Override
     public void grantTablePrivileges(ConnectorSession session, SchemaTableName schemaTableName, Set<Privilege> privileges, TrinoPrincipal grantee, boolean grantOption)
     {

diff --git a/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/AccessControlMetadata.java b/plugin/trino-hive/src/main/java/io/trino/plugin/hive/security/AccessControlMetadata.java
@@ -108,20 +108,36 @@ default Set<String> listEnabledRoles(ConnectorSession session)
         throw new TrinoException(NOT_SUPPORTED, "This connector does not support roles");
     }
 
+    /**
+     * Grants the specified privilege to the specified user on the specified schema
+     */
+    default void grantSchemaPrivileges(ConnectorSession session, String schemaName, Set<Privilege> privileges, HivePrincipal grantee, boolean grantOption)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support grants on schemas");
+    }
+
+    /**
+     * Revokes the specified privilege on the specified schema from the specified user
+     */
+    default void revokeSchemaPrivileges(ConnectorSession session, String schemaName, Set<Privilege> privileges, HivePrincipal grantee, boolean grantOption)
+    {
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support revokes on schemas");
+    }
+
     /**
      * Grants the specified privilege to the specified user on the specified table
      */
     default void grantTablePrivileges(ConnectorSession session, SchemaTableName tableName, Set<Privilege> privileges, HivePrincipal grantee, boolean grantOption)
     {
-        throw new TrinoException(NOT_SUPPORTED, "This connector does not support grants");
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support grants on tables");
     }
 
     /**
      * Revokes the specified privilege on the specified table from the specified user
      */
     default void revokeTablePrivileges(ConnectorSession session, SchemaTableName tableName, Set<Privilege> privileges, HivePrincipal grantee, boolean grantOption)
     {
-        throw new TrinoException(NOT_SUPPORTED, "This connector does not support revokes");
+        throw new TrinoException(NOT_SUPPORTED, "This connector does not support revokes on tables");
     }
 
     /**