Skip to content

Commit

Permalink
Split general configuration properties to their own fragment
Browse files Browse the repository at this point in the history
  • Loading branch information
hashhar committed Aug 4, 2021
1 parent 406e521 commit 4394ce9
Show file tree
Hide file tree
Showing 11 changed files with 47 additions and 19 deletions.
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/clickhouse.rst
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ appropriate for your setup:
connection-user=exampleuser
connection-password=examplepassword
.. include:: jdbc-common-configurations.fragment

Multiple ClickHouse servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/druid.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ secured by basic authentication by updating the URL and adding credentials:
Now you can access your Druid database in Trino with the ``druiddb`` catalog
name from the properties file.

.. include:: jdbc-common-configurations.fragment

.. _druid-type-mapping:

Type mapping
Expand Down
27 changes: 27 additions & 0 deletions docs/src/main/sphinx/connector/jdbc-common-configurations.fragment
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
General configuration properties
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The following table describes general configuration properties for the
connector:

.. list-table::
:widths: 30, 40, 30
:header-rows: 1

* - Property name
- Description
- Default value
* - ``case-insensitive-name-matching``
- Support case insensitive database and collection names
- False
* - ``case-insensitive-name-matching.cache-ttl``
-
- 1 minute
* - ``metadata.cache-ttl``
- Duration for which metadata, including table and column statistics, is
cached
- 0 (disabled caching)
* - ``metadata.cache-missing``
- Cache the fact that metadata, including table and column statistics, is
not available
- False
14 changes: 0 additions & 14 deletions docs/src/main/sphinx/connector/jdbc-type-mapping.fragment
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,3 @@ cached in Trino.
- Allow forced mapping of comma separated lists of data types to convert to
unbounded ``VARCHAR``
-
* - ``case-insensitive-name-matching``
- Support case insensitive database and collection names
- False
* - ``case-insensitive-name-matching.cache-ttl``
-
- 1 minute
* - ``metadata.cache-ttl``
- Duration for which metadata, including table and column statistics, is
cached
- 0 (disabled caching)
* - ``metadata.cache-missing``
- Cache the fact that metadata, including table and column statistics, is
not available
- False
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/memsql.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ connection properties as appropriate for your setup:
connection-user=root
connection-password=secret
.. include:: jdbc-common-configurations.fragment

Multiple SingleStore servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/mysql.rst
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ determine the user credentials for the connection, often a service user. You can
use :doc:`secrets </security/secrets>` to avoid actual values in the catalog
properties files.

.. include:: jdbc-common-configurations.fragment

Multiple MySQL servers
^^^^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/oracle.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ To disable connection pooling, update properties to include the following:
oracle.connection-pool.enabled=false
.. include:: jdbc-common-configurations.fragment

Multiple Oracle servers
^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
9 changes: 4 additions & 5 deletions docs/src/main/sphinx/connector/phoenix.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,7 @@ For HBase 2.x and Phoenix 5.x (5.1.0 or later) use:
connector.name=phoenix5
Configuration properties
------------------------

The following configuration properties are available:
The following Phoenix-specific configuration properties are available:

================================================== ========== ===================================================================================
Property Name Required Description
Expand All @@ -61,6 +58,8 @@ Property Name Required Description
connection properties. These files must exist on the machines running Trino.
================================================== ========== ===================================================================================

.. include:: jdbc-common-configurations.fragment

Querying Phoenix tables
-------------------------

Expand Down Expand Up @@ -185,4 +184,4 @@ Property Name Default Value Description
SQL support
-----------

.. include:: sql-delete-limitation.fragment
.. include:: sql-delete-limitation.fragment
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/postgresql.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ determine the user credentials for the connection, often a service user. You can
use :doc:`secrets </security/secrets>` to avoid actual values in the catalog
properties files.

.. include:: jdbc-common-configurations.fragment

Multiple PostgreSQL databases or servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/redshift.rst
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ connection properties as appropriate for your setup:
connection-user=root
connection-password=secret
.. include:: jdbc-common-configurations.fragment

Multiple Redshift databases or clusters
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
2 changes: 2 additions & 0 deletions docs/src/main/sphinx/connector/sqlserver.rst
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ determine the user credentials for the connection, often a service user. You can
use :doc:`secrets </security/secrets>` to avoid actual values in the catalog
properties files.

.. include:: jdbc-common-configurations.fragment

Multiple SQL Server databases or servers
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down

0 comments on commit 4394ce9

Please sign in to comment.