Skip to content

Commit

Permalink
Remove erroneous comment
Browse files Browse the repository at this point in the history
Window frame bound may be a non-literal expression. This is already
covered by existing test case
(`io.prestosql.tests.AbstractTestWindowQueries#testWindowFrames`).
  • Loading branch information
findepi committed Jun 27, 2019
1 parent 2b33e57 commit 304e8b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ frameBound
: UNBOUNDED boundType=PRECEDING #unboundedFrame
| UNBOUNDED boundType=FOLLOWING #unboundedFrame
| CURRENT ROW #currentRowBound
| expression boundType=(PRECEDING | FOLLOWING) #boundedFrame // expression should be unsignedLiteral
| expression boundType=(PRECEDING | FOLLOWING) #boundedFrame
;


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public void testStatementBuilder()
", rank() over (partition by depname order by salary desc)\n" +
", sum(salary) over (order by salary rows unbounded preceding)\n" +
", sum(salary) over (partition by depname order by salary rows between current row and 3 following)\n" +
", sum(salary) over (partition by depname order by salary rows between current row and empno following)\n" +
", sum(salary) over (partition by depname range unbounded preceding)\n" +
", sum(salary) over (rows between 2 preceding and unbounded following)\n" +
"from emp");
Expand Down

0 comments on commit 304e8b3

Please sign in to comment.