Add @fileexists validation to presto-local-file

trinodb · Jun 9, 2020 · 267c6f4 · 267c6f4
1 parent a55dfd9
commit 267c6f4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/presto-local-file/src/main/java/io/prestosql/plugin/localfile/LocalFileConfig.java b/presto-local-file/src/main/java/io/prestosql/plugin/localfile/LocalFileConfig.java
@@ -15,12 +15,14 @@
 
 import io.airlift.configuration.Config;
 import io.airlift.configuration.ConfigDescription;
+import io.airlift.configuration.validation.FileExists;
 
 public class LocalFileConfig
 {
     private String httpRequestLogLocation = "var/log/http-request.log";
     private String httpRequestLogFileNamePattern;
 
+    @FileExists
     public String getHttpRequestLogLocation()
     {
         return httpRequestLogLocation;

diff --git a/presto-local-file/src/test/java/io/prestosql/plugin/localfile/TestLocalFileConfig.java b/presto-local-file/src/test/java/io/prestosql/plugin/localfile/TestLocalFileConfig.java
@@ -16,6 +16,9 @@
 import com.google.common.collect.ImmutableMap;
 import org.testng.annotations.Test;
 
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.util.Map;
 
 import static io.airlift.configuration.testing.ConfigAssertions.assertFullMapping;
@@ -34,14 +37,17 @@ public void testDefaults()
 
     @Test
     public void testExplicitPropertyMappings()
+            throws IOException
     {
+        Path httpRequestLogFile = Files.createTempFile(null, null);
+
         Map<String, String> properties = new ImmutableMap.Builder<String, String>()
-                .put("presto-logs.http-request-log.location", "/data/foo.log")
+                .put("presto-logs.http-request-log.location", httpRequestLogFile.toString())
                 .put("presto-logs.http-request-log.pattern", "bar")
                 .build();
 
         LocalFileConfig expected = new LocalFileConfig()
-                .setHttpRequestLogLocation("/data/foo.log")
+                .setHttpRequestLogLocation(httpRequestLogFile.toString())
                 .setHttpRequestLogFileNamePattern("bar");
 
         assertFullMapping(properties, expected);