Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add episode 51 #547

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add episode 51 #547

merged 1 commit into from
Oct 10, 2023

Conversation

colebow
Copy link
Member

@colebow colebow commented Oct 3, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2023
@colebow colebow requested a review from mosabua October 3, 2023 16:55
_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Outdated
[PopSQL](https://popsql.com/), a playful spin on the word popsicle, solves the
sadness that is disorganized and siloed insights by centralizing queries into a
collaborative platform that has versioning, security, and a suite of
collaborative tools comparable to Google Drive. Want to work with your teammate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Google Drive they right comparison ..

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me - we sometimes compare it to Notion or Figma as well, the key features that are comparable to all those tools would be: file tree with folders and private vs team queries, multiplayer files (you can see when other people are in your query and what they are doing in realtime), comments, shareable links.

_episodes/51.md Outdated
collaborative platform that has versioning, security, and a suite of
collaborative tools comparable to Google Drive. Want to work with your teammate
on a query? You can open up the same editor and see the same thing. Want to see
what that query someone ran last week was to see how the new feature is doing?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is weird in this sentence ..

_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Show resolved Hide resolved
_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Show resolved Hide resolved
@mosabua
Copy link
Member

mosabua commented Oct 3, 2023

Maybe we can add a screenshot or two..

_episodes/51.md Outdated Show resolved Hide resolved
@colebow colebow force-pushed the colebow/tcb-51 branch 2 times, most recently from eb504df to 0757836 Compare October 5, 2023 16:24
_episodes/51.md Outdated
Comment on lines 101 to 123
and [lento](https://github.com/vweevers/lento), neither are great at streaming
data, and they lack some interactivity that could be used to make an interface

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lento actually has a great streaming interface, but:

  1. It requires you to purely interact against a singular stream object. We have a distributed architecture, and so trying to cancel a running query in a separate process would require us to implement our own call to the DELETE endpoint, and then make sure we propagate the timeout error properly
  2. It doesn't actually support trino out of the box. Adding support wouldn't be that hard, but given this comment by the maintainer, I don't think he's super interested in extending it, and along with (1) and some other minor things, we decided it wasn't a good fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some of this @colebow ?

Trino in the frontend is... a tricky thing. We can go ahead and admit that the
[Trino web UI](/docs/current/admin/web-interface.html) isn't going to win any
awards for design or functionality. And while a couple Node-based libraries
exist out there, including [presto-client-node](https://www.npmjs.com/package/presto-client)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We initially used this library, but in addition to the lack of streaming support, there's also some missing functionality (e.g. 50x errors throw an uncaught error) and some idiosyncrasies in the codebase (e.g. callbacks that have an err variable that's never defined), it's ended up not a great fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some of this @colebow ?

_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Outdated Show resolved Hide resolved

PopSQL and Trino make sense together. PopSQL provides a best-in-class interface
for organizing, collaborating, and working together on all of your SQL queries
across the business, and Trino handles running those queries at unparalleled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha .. unparalleled speed .. by parallel processing

Trino in the frontend is... a tricky thing. We can go ahead and admit that the
[Trino web UI](/docs/current/admin/web-interface.html) isn't going to win any
awards for design or functionality. And while a couple Node-based libraries
exist out there, including [presto-client-node](https://www.npmjs.com/package/presto-client)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some of this @colebow ?

_episodes/51.md Outdated
Comment on lines 101 to 123
and [lento](https://github.com/vweevers/lento), neither are great at streaming
data, and they lack some interactivity that could be used to make an interface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some of this @colebow ?

_episodes/51.md Outdated Show resolved Hide resolved
_episodes/51.md Show resolved Hide resolved
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@mosabua mosabua merged commit 4fb3e92 into trinodb:master Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants