ruby: use rb_interned_str when available #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API was introduced with Ruby 3.0 Ref: https://bugs.ruby-lang.org/issues/16029 It allows to re-used an existing interned string when possible. Since column names are very often present in the codebase, the hitrate is generally good. One issue here however is that column names are created in ASCII because the Ruby client doesn't know what the connection encoding is. So it won't be able to re-use literal strings from the codebase, however it will re-use the strings backing symbols (they are ASCII). But even on misses, since `Hash#[]=` will always try to dedup the string by always getting an interned string, we save that extra lookup later when using `Result#each_hash`.
matthewd
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was introduced with Ruby 3.0
Ref: https://bugs.ruby-lang.org/issues/16029
It allows to re-used an existing interned string when possible. Since column names are very often present in the codebase, the hitrate is generally good.
One issue here however is that column names are created in ASCII because the Ruby client doesn't know what the connection encoding is.
So it won't be able to re-use literal strings from the codebase, however it will re-use the strings backing symbols (they are ASCII).
But even on misses, since
Hash#[]=will always try to dedup the string by always getting an interned string, we save that extra lookup later when usingResult#each_hash.Similar change in MySQL2: brianmario/mysql2#1181