Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server config #655

Open
wants to merge 3 commits into
base: 0.3.x
Choose a base branch
from
Open

Server config #655

wants to merge 3 commits into from

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Jun 3, 2024

closes #657

@jbr jbr changed the base branch from main to 0.3.x June 3, 2024 22:38
Self::validate_headers(&request_headers)?;

let mut response_headers = Headers::new();
response_headers.insert(Server, SERVER);

Check failure

Code scanning / clippy

cannot find value `Server` in this scope

cannot find value `Server` in this scope
Self::validate_headers(&request_headers)?;

let mut response_headers = Headers::new();
response_headers.insert(Server, SERVER);

Check failure

Code scanning / clippy

cannot find value `SERVER` in this scope

cannot find value `SERVER` in this scope
buffer,
response_headers,
status: None,
state: TypeSet::new(),

Check failure

Code scanning / clippy

failed to resolve: use of undeclared type `TypeSet`

failed to resolve: use of undeclared type `TypeSet`
response_body: None,
request_body_state: ReceivedBodyState::Start,
secure: false,
after_send: AfterSend::default(),

Check failure

Code scanning / clippy

failed to resolve: use of undeclared type `AfterSend`

failed to resolve: use of undeclared type `AfterSend`
let first_space = spaces.next().ok_or(Error::MissingMethod)?;
let method = Method::parse(&buffer[0..first_space])?;
let second_space = spaces.next().ok_or(Error::RequestPathMissing)?;
let path = str::from_utf8(&buffer[first_space + 1..second_space])

Check failure

Code scanning / clippy

no function or associated item named `from_utf8` found for type `str` in the current scope

no function or associated item named `from_utf8` found for type `str` in the current scope
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 351 lines in your changes missing coverage. Please review.

Project coverage is 52.17%. Comparing base (81ad587) to head (84ef233).

Files Patch % Lines
client/src/conn/implementation.rs 61.56% 103 Missing ⚠️
http/src/conn/implementation.rs 83.11% 39 Missing ⚠️
server-common/src/config.rs 72.83% 22 Missing ⚠️
server-common/src/server.rs 44.11% 19 Missing ⚠️
logger/src/lib.rs 6.25% 15 Missing ⚠️
server-common/src/running_config.rs 70.58% 15 Missing ⚠️
trillium/src/info.rs 52.00% 12 Missing ⚠️
client/src/conn.rs 15.38% 11 Missing ⚠️
client/src/conn/unexpected_status_error.rs 0.00% 11 Missing ⚠️
aws-lambda/src/lib.rs 0.00% 9 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #655      +/-   ##
==========================================
- Coverage   52.61%   52.17%   -0.44%     
==========================================
  Files         198      205       +7     
  Lines        7534     7603      +69     
==========================================
+ Hits         3964     3967       +3     
- Misses       3570     3636      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant