Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Runtime trait and type #641

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Introduce Runtime trait and type #641

merged 2 commits into from
Apr 19, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 18, 2024

No description provided.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 71.76471% with 96 lines in your changes are missing coverage. Please review.

Project coverage is 52.27%. Comparing base (63e23d1) to head (257b7d1).
Report is 1 commits behind head on 0.3.x.

Files Patch % Lines
testing/src/runtimeless/runtime.rs 61.53% 15 Missing ⚠️
tokio/src/runtime.rs 63.63% 12 Missing ⚠️
server-common/src/runtime.rs 62.06% 11 Missing ⚠️
async-std/src/runtime.rs 60.00% 8 Missing ⚠️
smol/src/server/tcp.rs 0.00% 8 Missing ⚠️
smol/src/runtime.rs 73.07% 7 Missing ⚠️
testing/src/runtimeless/server.rs 80.00% 6 Missing ⚠️
server-common/src/runtime/object_safe_runtime.rs 50.00% 4 Missing ⚠️
tokio/src/server/tcp.rs 0.00% 4 Missing ⚠️
async-std/src/server/tcp.rs 0.00% 3 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #641      +/-   ##
==========================================
+ Coverage   51.54%   52.27%   +0.72%     
==========================================
  Files         184      194      +10     
  Lines        7209     7331     +122     
==========================================
+ Hits         3716     3832     +116     
- Misses       3493     3499       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr force-pushed the runtime branch 5 times, most recently from 5b91506 to 9a0054b Compare April 19, 2024 19:03
@jbr jbr changed the title Runtime Introduce Runtime trait and type Apr 19, 2024
@jbr jbr force-pushed the runtime branch 2 times, most recently from 7427a20 to e9ff8d3 Compare April 19, 2024 20:44
@jbr jbr merged commit c8a46cc into 0.3.x Apr 19, 2024
7 checks passed
@jbr jbr deleted the runtime branch April 19, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant