Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): impl IntoUrl for IpAddr and SocketAddr for convenience #638

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 17, 2024

No description provided.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 48.81%. Comparing base (0bc2435) to head (17c3478).

❗ Current head 17c3478 differs from pull request most recent head ec31e03. Consider uploading reports for the commit ec31e03 to get more accurate results

Files Patch % Lines
client/src/into_url.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   48.85%   48.81%   -0.05%     
==========================================
  Files         183      183              
  Lines        7242     7248       +6     
==========================================
  Hits         3538     3538              
- Misses       3704     3710       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr force-pushed the implement-into-url-for-socket-addr-and-ip-addr branch from 17c3478 to ec31e03 Compare April 17, 2024 19:27
@jbr jbr merged commit f803ff9 into main Apr 17, 2024
8 checks passed
@jbr jbr deleted the implement-into-url-for-socket-addr-and-ip-addr branch April 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant