Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use swansong instead of stopper + clone counter #623

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 7, 2024

No description provided.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 49.94%. Comparing base (15029f8) to head (bc729de).

Files Patch % Lines
smol/src/server/unix.rs 47.36% 10 Missing ⚠️
http/src/conn.rs 62.50% 6 Missing ⚠️
proxy/src/upstream/connection_counting.rs 0.00% 5 Missing ⚠️
async-std/src/server/unix.rs 0.00% 3 Missing ⚠️
server-common/src/config.rs 62.50% 3 Missing ⚠️
server-common/src/server_handle.rs 40.00% 3 Missing ⚠️
tokio/src/server/unix.rs 0.00% 3 Missing ⚠️
websockets/src/websocket_connection.rs 50.00% 2 Missing ⚠️
http/src/upgrade.rs 75.00% 1 Missing ⚠️
sse/src/lib.rs 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #623      +/-   ##
==========================================
- Coverage   50.10%   49.94%   -0.16%     
==========================================
  Files         184      183       -1     
  Lines        7153     6967     -186     
==========================================
- Hits         3584     3480     -104     
+ Misses       3569     3487      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr merged commit ff2a4ad into 0.3.x Apr 7, 2024
7 checks passed
@jbr jbr deleted the swansong branch April 7, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant