Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http patch: add in the notion of received_body_max_preallocate #417

Merged
merged 1 commit into from
Oct 26, 2023

add in the notion of received_body_max_preallocate

10e4380
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

http patch: add in the notion of received_body_max_preallocate #417

add in the notion of received_body_max_preallocate
10e4380
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 26, 2023 in 0s

clippy

19 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 19
Note 0
Help 0

Versions

  • rustc 1.75.0-nightly (df871fbf0 2023-10-24)
  • cargo 1.75.0-nightly (d2f6a0485 2023-10-20)
  • clippy 0.1.75 (df871fb 2023-10-24)

Annotations

Check warning on line 94 in sse/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `default` to create a unit struct

warning: use of `default` to create a unit struct
  --> sse/src/lib.rs:94:31
   |
94 |             event: PhantomData::default(),
   |                               ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

Check warning on line 209 in proxy/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

explicit call to `.into_iter()` in function argument accepting `IntoIterator`

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
   --> proxy/src/lib.rs:209:29
    |
209 |                     .extend(std::mem::take(client_conn.response_headers_mut()).into_iter());
    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `std::mem::take(client_conn.response_headers_mut())`
    |
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
   --> /rustc/df871fbf053de3a855398964cd05fadbe91cf4fd/library/core/src/iter/traits/collect.rs:372:18
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

Check warning on line 451 in client/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> client/src/conn.rs:451:13
    |
451 |             &mut self.response_body_state,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.response_body_state`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 537 in trillium/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function which may panic missing `# Panics` section

warning: docs for function which may panic missing `# Panics` section
   --> trillium/src/conn.rs:537:5
    |
537 |     pub fn into_inner<T: Transport>(self) -> trillium_http::Conn<T> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: first possible panic found here
   --> trillium/src/conn.rs:539:14
    |
539 |               *t.downcast()
    |  ______________^
540 | |                 .expect("attempted to downcast to the wrong transport type")
    | |____________________________________________________________________________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
    = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 281 in trillium/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> trillium/src/conn.rs:281:16
    |
281 |     Returns a [ReceivedBody] that references this `Conn`. The `Conn`
    |                ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
   --> trillium/src/lib.rs:10:23
    |
10  | #![warn(missing_docs, clippy::pedantic, clippy::nursery, clippy::cargo)]
    |                       ^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
281 |     Returns a [`ReceivedBody`] that references this `Conn`. The `Conn`
    |                ~~~~~~~~~~~~~~

Check warning on line 1 in trillium/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple versions for dependency `futures-lite`: 1.13.0, 2.0.0

warning: multiple versions for dependency `futures-lite`: 1.13.0, 2.0.0
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions

Check warning on line 1 in trillium/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple versions for dependency `fastrand`: 1.9.0, 2.0.1

warning: multiple versions for dependency `fastrand`: 1.9.0, 2.0.1
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions
note: the lint level is defined here
  --> trillium/src/lib.rs:10:58
   |
10 | #![warn(missing_docs, clippy::pedantic, clippy::nursery, clippy::cargo)]
   |                                                          ^^^^^^^^^^^^^
   = note: `#[warn(clippy::multiple_crate_versions)]` implied by `#[warn(clippy::cargo)]`

Check warning on line 54 in http/src/transport/boxed_transport.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
  --> http/src/transport/boxed_transport.rs:54:18
   |
54 |     Create a new BoxedTransport from some Transport.
   |                  ^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
   |
54 |     Create a new `BoxedTransport` from some Transport.
   |                  ~~~~~~~~~~~~~~~~

Check warning on line 93 in http/src/headers/header_name.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

matching over `()` is more explicit

warning: matching over `()` is more explicit
  --> http/src/headers/header_name.rs:93:21
   |
93 |                 Err(_) => UnknownHeader(UnknownHeaderName(SmartCow::Owned(SmartString::from(s)))),
   |                     ^ help: use `()` instead of `_`: `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns

Check warning on line 78 in http/src/state_set.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function which may panic missing `# Panics` section

warning: docs for function which may panic missing `# Panics` section
  --> http/src/state_set.rs:75:5
   |
75 | /     pub fn get_or_insert_with<F, T>(&mut self, default: F) -> &mut T
76 | |     where
77 | |         F: FnOnce() -> T,
78 | |         T: Send + Sync + 'static,
   | |_________________________________^
   |
note: first possible panic found here
  --> http/src/state_set.rs:80:9
   |
80 | /         self.0
81 | |             .entry(TypeId::of::<T>())
82 | |             .or_insert_with(|| Box::new(default()))
83 | |             .downcast_mut()
84 | |             .expect("StateSet maintains the invariant the value associated with a given TypeId is always the type associated with that TypeId.")
   | |________________________________________________________________________________________________________________________________________________^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

Check warning on line 65 in http/src/state_set.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

docs for function which may panic missing `# Panics` section

warning: docs for function which may panic missing `# Panics` section
  --> http/src/state_set.rs:65:5
   |
65 |     pub fn get_or_insert<T: Send + Sync + 'static>(&mut self, default: T) -> &mut T {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: first possible panic found here
  --> http/src/state_set.rs:66:9
   |
66 | /         self.0
67 | |             .entry(TypeId::of::<T>())
68 | |             .or_insert_with(|| Box::new(default))
69 | |             .downcast_mut()
70 | |             .expect("StateSet maintains the invariant the value associated with a given TypeId is always the type associated with that TypeId.")
   | |________________________________________________________________________________________________________________________________________________^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
   = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 111 in http/src/upgrade.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual `Debug` impl does not include all fields

warning: manual `Debug` impl does not include all fields
   --> http/src/upgrade.rs:99:1
    |
99  | / impl<Transport> Debug for Upgrade<Transport> {
100 | |     fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result {
101 | |         f.debug_struct(&format!("Upgrade<{}>", std::any::type_name::<Transport>()))
102 | |             .field("request_headers", &self.request_headers)
...   |
110 | |     }
111 | | }
    | |_^
    |
note: this field is unused
   --> http/src/upgrade.rs:32:5
    |
32  |     pub state: StateSet,
    |     ^^^^^^^^^^^^^^^^^^^
note: this field is unused
   --> http/src/upgrade.rs:35:5
    |
35  |     pub transport: Transport,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
note: this field is unused
   --> http/src/upgrade.rs:43:5
    |
43  |     pub stopper: Stopper,
    |     ^^^^^^^^^^^^^^^^^^^^
    = help: consider including all fields in this `Debug` impl
    = help: consider calling `.finish_non_exhaustive()` if you intend to ignore fields
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_fields_in_debug
    = note: `#[warn(clippy::missing_fields_in_debug)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 93 in http/src/synthetic.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

matching over `()` is more explicit

warning: matching over `()` is more explicit
  --> http/src/synthetic.rs:93:13
   |
93 |     fn from(_: ()) -> Self {
   |             ^ help: use `()` instead of `_`: `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
   = note: `#[warn(clippy::ignored_unit_patterns)]` implied by `#[warn(clippy::pedantic)]`

Check warning on line 652 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> http/src/conn.rs:652:22
    |
652 |     processing in an after_send hook, please open an issue. This hook
    |                      ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
    |
652 |     processing in an `after_send` hook, please open an issue. This hook
    |                      ~~~~~~~~~~~~

Check warning on line 421 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> http/src/conn.rs:421:5
    |
421 |     ReceivedBody provides an interface to read body content
    |     ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
    |
421 |     `ReceivedBody` provides an interface to read body content
    |     ~~~~~~~~~~~~~~

Check warning on line 419 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> http/src/conn.rs:419:16
    |
419 |     returns a [ReceivedBody] that references this conn. the conn
    |                ^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
    |
419 |     returns a [`ReceivedBody`] that references this conn. the conn
    |                ~~~~~~~~~~~~~~

Check warning on line 403 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> http/src/conn.rs:403:18
    |
403 |     returns the [encoding_rs::Encoding] for this response, as
    |                  ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
    |
403 |     returns the [`encoding_rs::Encoding`] for this response, as
    |                  ~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 387 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

item in documentation is missing backticks

warning: item in documentation is missing backticks
   --> http/src/conn.rs:387:18
    |
387 |     returns the [encoding_rs::Encoding] for this request, as
    |                  ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
   --> http/src/lib.rs:10:23
    |
10  | #![warn(missing_docs, clippy::pedantic, clippy::perf, clippy::cargo)]
    |                       ^^^^^^^^^^^^^^^^
    = note: `#[warn(clippy::doc_markdown)]` implied by `#[warn(clippy::pedantic)]`
help: try
    |
387 |     returns the [`encoding_rs::Encoding`] for this request, as
    |                  ~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 379 in http/src/conn.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> http/src/conn.rs:379:13
    |
379 |             &mut self.request_body_state,
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.request_body_state`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default