Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nodelay on prebound server #393

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Oct 18, 2023

closes #392

@jbr jbr force-pushed the allow-nodelay-on-prebound-server branch from 76727d7 to 8e2e4d2 Compare October 18, 2023 03:28
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e9a40d9) 45.11% compared to head (8e2e4d2) 45.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   45.11%   45.14%   +0.02%     
==========================================
  Files         156      156              
  Lines        6133     6129       -4     
==========================================
  Hits         2767     2767              
+ Misses       3366     3362       -4     
Files Coverage Δ
server-common/src/config.rs 62.76% <ø> (+2.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr merged commit 40830c8 into main Oct 18, 2023
20 checks passed
@jbr jbr deleted the allow-nodelay-on-prebound-server branch October 18, 2023 03:43
@joshtriplett
Copy link
Collaborator

Thank you, I really appreciate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with_nodelay on prebound server
2 participants