Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify trillium_server_common::Acceptor to return an Option #376

Closed
wants to merge 1 commit into from

Conversation

joshtriplett
Copy link
Collaborator

This allows an Acceptor to handle some connections entirely internally
and not produce a stream to handle requests from.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch coverage: 56.25% and project coverage change: -0.09% ⚠️

Comparison is base (0853e5d) 45.03% compared to head (d64013c) 44.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   45.03%   44.94%   -0.09%     
==========================================
  Files         156      156              
  Lines        6104     6107       +3     
==========================================
- Hits         2749     2745       -4     
- Misses       3355     3362       +7     
Files Changed Coverage Δ
native-tls/src/server.rs 50.00% <50.00%> (-7.15%) ⬇️
rustls/src/server.rs 63.15% <50.00%> (-10.18%) ⬇️
server-common/src/config_ext.rs 40.25% <50.00%> (-0.53%) ⬇️
server-common/src/acceptor.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This allows an `Acceptor` to handle some connections entirely internally
and not produce a stream to handle requests from.
@joshtriplett
Copy link
Collaborator Author

Closing this in favor of #377 which uses the suggested approach of returning a dummy Transport after processing a challenge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants