Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config with listener #309

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Config with listener #309

merged 3 commits into from
Sep 13, 2023

Conversation

jbr
Copy link
Contributor

@jbr jbr commented Apr 6, 2023

closes #200

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 19.14% and project coverage change: -0.22% ⚠️

Comparison is base (7fd3b60) 45.25% compared to head (a6efd9b) 45.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   45.25%   45.03%   -0.22%     
==========================================
  Files         156      156              
  Lines        6057     6104      +47     
==========================================
+ Hits         2741     2749       +8     
- Misses       3316     3355      +39     
Files Changed Coverage Δ
async-std/src/lib.rs 0.00% <ø> (ø)
async-std/src/server/unix.rs 0.00% <0.00%> (ø)
smol/src/lib.rs 66.66% <ø> (ø)
smol/src/server/unix.rs 50.00% <0.00%> (-5.89%) ⬇️
tokio/src/lib.rs 0.00% <ø> (ø)
tokio/src/server/tcp.rs 0.00% <0.00%> (ø)
tokio/src/server/unix.rs 0.00% <0.00%> (ø)
server-common/src/server.rs 59.18% <16.66%> (-5.94%) ⬇️
server-common/src/config.rs 60.20% <34.78%> (-7.80%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbr jbr force-pushed the config-with-listener branch 2 times, most recently from 6df5c2f to 5ac2d9a Compare April 6, 2023 23:17
@jbr jbr merged commit be6a289 into main Sep 13, 2023
20 of 21 checks passed
@jbr jbr deleted the config-with-listener branch September 13, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature for all runtime adapters: add the ability to provide a pre-bound TcpListener instead of host+port
1 participant