Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed note about Flex #57

Merged
merged 2 commits into from
Aug 17, 2019
Merged

Removed note about Flex #57

merged 2 commits into from
Aug 17, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented May 29, 2019

Every package is compatible with Flex. However, you mean that you dont have a recipe.

I think this package is an excellent candidate for a recipe. We should add something like this to a recipe to make the bundle installable:

trikoder_oauth2:
  authorization_server:
    private_key: /var/oauth/private.key # Change this
    encryption_key: 'foobar' # Change this
  resource_server:
    public_key: /var/oauth/public.key # Change this
  persistence:
    doctrine: ~

If you submit a recipe to https://github.com/symfony/recipes-contrib I would be happy to approve it.

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #57   +/-   ##
========================================
  Coverage      90.8%   90.8%           
  Complexity      280     280           
========================================
  Files            43      43           
  Lines           979     979           
========================================
  Hits            889     889           
  Misses           90      90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa60ef...5de1154. Read the comment docs.

@spideyfusion
Copy link
Contributor

@Nyholm @Allypost created a pull request for the Symfony recipe, but for some reason the build fails on PHP 7.4: symfony/recipes-contrib#728

@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 13, 2019

Hm. Master is red in symfony/recipes-contrib. I'll check.

@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 13, 2019

The recipe is merged.

Thank you @Allypost

@spideyfusion spideyfusion changed the base branch from master to v2.x August 13, 2019 17:30
@spideyfusion
Copy link
Contributor

Glad to finally have this PR resolved, thanks @Nyholm! 😄

@spideyfusion spideyfusion merged commit a4ccea1 into trikoder:v2.x Aug 17, 2019
@Nyholm Nyholm deleted the patch-1 branch August 17, 2019 14:42
@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 17, 2019

Thank you

@spideyfusion spideyfusion added this to the v2.1 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants