Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isRequired() from doctrine config #56

Merged
merged 1 commit into from
May 29, 2019

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented May 29, 2019

This would allow me to write:

trikoder_oauth2:
  persistence:
    doctrine: ~

If we do have isRequired() then there is no point in specifying a default value for entity_manager

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #56 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #56      +/-   ##
===========================================
- Coverage     90.81%   90.8%   -0.01%     
  Complexity      280     280              
===========================================
  Files            43      43              
  Lines           980     979       -1     
===========================================
- Hits            890     889       -1     
  Misses           90      90
Impacted Files Coverage Δ Complexity Δ
DependencyInjection/Configuration.php 100% <ø> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad80d0...8954f00. Read the comment docs.

Copy link
Collaborator

@X-Coder264 X-Coder264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Nyholm.

@X-Coder264 X-Coder264 merged commit 5fa60ef into trikoder:master May 29, 2019
@Nyholm Nyholm deleted the patch-1 branch May 29, 2019 09:38
@Nyholm
Copy link
Contributor Author

Nyholm commented May 29, 2019

Thank you for merging

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.80%. Comparing base (7ad80d0) to head (8954f00).
Report is 385 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
- Coverage     90.81%   90.80%   -0.01%     
  Complexity      280      280              
============================================
  Files            43       43              
  Lines           980      979       -1     
============================================
- Hits            890      889       -1     
  Misses           90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants