Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command : Clean expired OAuth2 tokens #55

Closed
wants to merge 2 commits into from

Conversation

anthony-launay
Copy link

@anthony-launay anthony-launay commented May 23, 2019

New command to clean expired OAuth2 tokens

@codecov-io
Copy link

Codecov Report

Merging #55 into master will decrease coverage by 2.33%.
The diff coverage is 19.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     89.95%   87.61%   -2.34%     
- Complexity      267      274       +7     
============================================
  Files            42       44       +2     
  Lines           916      945      +29     
============================================
+ Hits            824      828       +4     
- Misses           92      117      +25
Impacted Files Coverage Δ Complexity Δ
Command/CleanCommand.php 0% <0%> (ø) 4 <4> (?)
Manager/Doctrine/RefreshTokenManager.php 100% <100%> (ø) 4 <0> (ø) ⬇️
Manager/Doctrine/AccessTokenManager.php 100% <100%> (ø) 4 <0> (ø) ⬇️
Manager/Doctrine/TokenManager.php 14.28% <14.28%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baffa92...a32bc0d. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #55 into master will decrease coverage by 2.33%.
The diff coverage is 19.35%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     89.95%   87.61%   -2.34%     
- Complexity      267      274       +7     
============================================
  Files            42       44       +2     
  Lines           916      945      +29     
============================================
+ Hits            824      828       +4     
- Misses           92      117      +25
Impacted Files Coverage Δ Complexity Δ
Command/CleanCommand.php 0% <0%> (ø) 4 <4> (?)
Manager/Doctrine/RefreshTokenManager.php 100% <100%> (ø) 4 <0> (ø) ⬇️
Manager/Doctrine/AccessTokenManager.php 100% <100%> (ø) 4 <0> (ø) ⬇️
Manager/Doctrine/TokenManager.php 14.28% <14.28%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baffa92...a32bc0d. Read the comment docs.

@HypeMC
Copy link
Contributor

HypeMC commented May 23, 2019

@anthony-launay Thank you for the PR, but this has already been resolved with #53

@HypeMC HypeMC closed this May 23, 2019
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.35484% with 25 lines in your changes missing coverage. Please review.

Project coverage is 87.61%. Comparing base (baffa92) to head (a32bc0d).
Report is 390 commits behind head on master.

Files with missing lines Patch % Lines
Command/CleanCommand.php 0.00% 13 Missing ⚠️
Manager/Doctrine/TokenManager.php 14.28% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
- Coverage     89.95%   87.61%   -2.34%     
- Complexity      267      274       +7     
============================================
  Files            42       44       +2     
  Lines           916      945      +29     
============================================
+ Hits            824      828       +4     
- Misses           92      117      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants