Add missing console commands for client management #41

Allypost · 2019-04-16T16:54:28Z

Fix #3

Command/DeleteClientCommand.php

Command/ListClientsCommand.php

Manager/ClientFilter.php

Manager/ClientManagerInterface.php

Manager/Doctrine/ClientManager.php

Manager/InMemory/ClientManager.php

Tests/Acceptance/ListClientsCommandTest.php

X-Coder264 · 2019-04-21T21:41:58Z

Manager/ClientManagerInterface.php

@@ -9,4 +9,11 @@ interface ClientManagerInterface
    public function find(string $identifier): ?Client;

    public function save(Client $client): void;
+
+    public function remove(Client $client): void;


@Allypost @spideyfusion Adding methods to an interface is a breaking change and as such this PR can be merged only for the next major version which I suppose will be tagged soon after #43 gets merged.

@X-Coder264 Yeah this will get merged after the version bump.

@Allypost My point was this should be merged before the next major version gets tagged. Anyway, this discussion isn't important for this PR, @spideyfusion will take care of that :)

@X-Coder264 Indeed. :)

Command/ListClientsCommand.php

Manager/ClientFilter.php

Manager/ClientManagerInterface.php

Command/ListClientsCommand.php

Tests/Acceptance/DeleteClientCommandTest.php

…EntityManagerInterface`

Manager/ClientFilter.php

Command/ListClientsCommand.php

codecov-io · 2019-05-07T09:04:34Z

Codecov Report

Merging #41 into master will increase coverage by 0.85%.
The diff coverage is 86.62%.

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     88.93%   89.78%   +0.85%     
- Complexity      222      264      +42     
============================================
  Files            39       42       +3     
  Lines           759      901     +142     
============================================
+ Hits            675      809     +134     
- Misses           84       92       +8

Impacted Files	Coverage Δ	Complexity Δ
Manager/InMemory/ClientManager.php	`19.04% <0%> (-80.96%)`	`12 <9> (+9)`
Command/DeleteClientCommand.php	`100% <100%> (ø)`	`4 <4> (?)`
Command/UpdateClientCommand.php	`96.22% <100%> (ø)`	`5 <3> (ø)`	⬇️
Manager/ClientFilter.php	`100% <100%> (ø)`	`12 <12> (?)`
Command/CreateClientCommand.php	`100% <100%> (ø)`	`4 <1> (ø)`	⬇️
Manager/Doctrine/ClientManager.php	`92.85% <90.47%> (-7.15%)`	`14 <10> (+10)`
Command/ListClientsCommand.php	`96.77% <96.77%> (ø)`	`7 <7> (?)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f6641...f58c052. Read the comment docs.

spideyfusion suggested changes Apr 17, 2019

View reviewed changes

Command/DeleteClientCommand.php Outdated Show resolved Hide resolved

Command/DeleteClientCommand.php Outdated Show resolved Hide resolved

Command/ListClientsCommand.php Outdated Show resolved Hide resolved

Command/ListClientsCommand.php Outdated Show resolved Hide resolved

spideyfusion suggested changes Apr 17, 2019

View reviewed changes

X-Coder264 reviewed Apr 21, 2019

View reviewed changes

X-Coder264 mentioned this pull request Apr 21, 2019

Create console commands for listing and deleting clients #44

Closed

HypeMC reviewed Apr 23, 2019

View reviewed changes

Allypost added 25 commits May 6, 2019 12:49

Added client Delete command

77b7190

Lint oopsie doopsie

a6cafbe

Added client Delete command test

7122d20

Added client List command

d471074

Registered new list and delete commands

5c005a3

Now actually checking if client is deleted

dc5b3df

Removed superfluous assert

6ca5710

Added client list command tests

a18bf03

Updated docs

dcd8a0f

Added required methods to ClientManagerInterface instead of using `…

182f26b

…EntityManagerInterface`

Moved fixtures to tests that actually need them

935956f

Changed list tests to assert that the table has a constant form

4a2ea0a

Added ClientFilter to unify filtering lists

e3a343d

Implemented filtering for memory client

462cd6b

Added default value (list all) to ListClients columns parameter

b1cad99

Oopsie doopsie lint results

f6bef37

Allowed columns is now static

abe0020

Tightened up checks

dbd091f

Now using builtin function to map to string

01f8bfa

$repository->findAll() === $repository->findBy([])

35defac

Naming :)

16b5d5d

Renamed ClientFilter::createFilter -> ClientFilter::create

bbc5437

Added nulls to phpdoc

7268ab4

Added empty client list test

40ec5fd

Moved duplicate logic to own method

4468133

Allypost added 10 commits May 6, 2019 12:49

Some more explicit null checks

8e7d9e2

Renamed client filter argument to make a bit more sense

e3d4e9e

Made list command arguments arrays

0ed7310

Values no longer optional

1353ca8

Fix invalid hasFilters check

6e12755

Add missing typehints

86cbd10

Fix invalid PHPDoc comment style

965ef14

Updated command option description

2a370c5

ClientFilter add*Criteria now takes list or arguments

9e21ee0

All arguments are now required if they have a value

2f5df30

HypeMC suggested changes May 6, 2019

View reviewed changes

Manager/ClientFilter.php Outdated Show resolved Hide resolved

Manager/ClientFilter.php Show resolved Hide resolved

Command/ListClientsCommand.php Outdated Show resolved Hide resolved

Allypost added 2 commits May 7, 2019 10:06

Relinquish last surviving VALUE_OPTIONAL

d0351d7

ClientFilter values now always arrays

f58c052

HypeMC approved these changes May 7, 2019

View reviewed changes

HypeMC merged commit 56aafba into trikoder:master May 7, 2019

X-Coder264 mentioned this pull request May 10, 2019

Create console commands for listing and deleting clients #36

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing console commands for client management #41

Add missing console commands for client management #41

Allypost commented Apr 16, 2019

X-Coder264 Apr 21, 2019

Allypost May 6, 2019

X-Coder264 May 6, 2019

spideyfusion May 6, 2019

codecov-io commented May 7, 2019

Add missing console commands for client management #41

Add missing console commands for client management #41

Conversation

Allypost commented Apr 16, 2019

X-Coder264 Apr 21, 2019

Choose a reason for hiding this comment

Allypost May 6, 2019

Choose a reason for hiding this comment

X-Coder264 May 6, 2019

Choose a reason for hiding this comment

spideyfusion May 6, 2019

Choose a reason for hiding this comment

codecov-io commented May 7, 2019

Codecov Report