-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass CryptKey instance to oauth2 with permission check disabled #10
Pass CryptKey instance to oauth2 with permission check disabled #10
Conversation
…on check disabled. Fix permission check (introduced with thephpleague/oauth2-server#776) for private keys always failing in windows environments (also docker). Shamelessly stolen from laravel/passport#454.
O.k... it's my first PR ever... so be tolerant 😟 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. I've left some feedback for you to address. :-)
Co-Authored-By: gschafra <[email protected]>
Unfortunately, when I'm trying to run php via docker on my Windows machine here (company conventions, sorry), running Docker for Windows using: D:\vlinux\oauth2-bundle (disable-private-key-permission-check -> origin) λ docker-compose run --rm --no-deps php -v
WARNING: The HOST_USER_ID variable is not set. Defaulting to a blank string.
WARNING: The HOST_GROUP_ID variable is not set. Defaulting to a blank string.
sh: can't open 'docker-entrypoint': No such file or directory Already tried to set |
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
+ Coverage 85.97% 86% +0.02%
Complexity 197 197
=========================================
Files 37 37
Lines 599 600 +1
=========================================
+ Hits 515 516 +1
Misses 84 84
Continue to review full report at Codecov.
|
- Applied on tests and extension class
So... applied everything as suggested, run lint and unit tests (also locally). There's still the requested change open (see above)... is there something left open to do for me (concerning this PR of course ;-) )? |
Fix permission check (introduced with thephpleague/oauth2-server#776) for private keys
always failing in windows environments (also docker). Shamelessly stolen from laravel/passport#454.