-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update backend #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbar01234
reviewed
Apr 5, 2024
nickbar01234
reviewed
Apr 5, 2024
nickbar01234
previously requested changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good so far! A couple of details to consider about:
- Determine whether a package should be in
dependencies
ordevDependencies
- Potentially updating
schema.prisma
- A trip has many activities, so we should reflect that relationship here. You may find this helpful
- When we delete a trip or modify it, we need to ensure that all the relationships are properly updated.
- For a 1-to-many relationship, deleting a trip means that all associated activities should be deleted. The native way to do it using Prisma is with referential action
- This means that if you allow
PUT /trips/:id
to modify activities and participants, you should check whether the relationship is consistent after the API call.
trihoang0809
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
trihoang0809
approved these changes
Apr 8, 2024
tranguv
dismissed
nickbar01234’s stale review
April 12, 2024 00:46
Change requested has been opened in a new Github issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description