Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to authenticate with redis servers #89

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

stewrutledgebonnier
Copy link
Contributor

We have all of our redis instances setup with authentication which makes using them as a backend impossible.

This change just adds AUTH support to the redis client, based on the presence of password in the configuration file.

@CLAassistant
Copy link

CLAassistant commented Aug 15, 2018

CLA assistant check
All committers have signed the CLA.

@jranson
Copy link
Member

jranson commented Aug 15, 2018

@juliusv Any concerns about this one (e.g., storing passwords in plaintext)?

@SuperQ
Copy link
Collaborator

SuperQ commented Aug 15, 2018

Storing credentials in a file is the preferred thing these days. LGTM.

@stewrutledgebonnier
Copy link
Contributor Author

stewrutledgebonnier commented Aug 15, 2018 via email

@SuperQ
Copy link
Collaborator

SuperQ commented Aug 15, 2018

ENV vars are considered unsafe compared to files.

@stewrutledgebonnier
Copy link
Contributor Author

stewrutledgebonnier commented Aug 15, 2018 via email

@jranson jranson merged commit d20f0a9 into trickstercache:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants