Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logging #733

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Refactor logging #733

merged 5 commits into from
Aug 16, 2024

Conversation

jranson
Copy link
Member

@jranson jranson commented Aug 16, 2024

this Patch removes the go-stack and go-kit/log dependencies in the logging package and refactors all logging calls across the project to work with the new logger.

@jranson jranson merged commit c98f5fd into trickstercache:main Aug 16, 2024
5 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10412731650

Details

  • 294 of 407 (72.24%) changed or added relevant lines in 39 files are covered.
  • 18 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.4%) to 89.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cache/badger/badger.go 7 8 87.5%
pkg/cache/redis/redis.go 9 10 90.0%
pkg/backends/prometheus/model/vector.go 1 3 33.33%
pkg/cache/bbolt/bbolt.go 9 11 81.82%
pkg/cache/index/index.go 13 15 86.67%
pkg/proxy/engines/httpproxy.go 5 7 71.43%
pkg/proxy/engines/proxy_request.go 0 2 0.0%
pkg/proxy/listener/listener.go 14 16 87.5%
pkg/httpserver/signal/signal.go 1 4 25.0%
pkg/proxy/handlers/purge.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/backends/prometheus/model/vector.go 1 92.06%
pkg/proxy/listener/listener.go 1 93.37%
pkg/proxy/engines/httpproxy.go 1 78.08%
pkg/cache/bbolt/bbolt.go 2 88.69%
pkg/observability/logging/logging.go 13 66.67%
Totals Coverage Status
Change from base Build 10407707795: -0.4%
Covered Lines: 17142
Relevant Lines: 19076

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants