-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker image publishing workflows #712
Conversation
Signed-off-by: Starttoaster <[email protected]>
Signed-off-by: Starttoaster <[email protected]>
Ah, my commits are signed but not signed off on. So I'm failing that DCO check. Will fix that but will have to force push it up. edit: Fixed signoffs. |
FYI, I set up mostly the same workflows in a repo of my own just to try them out, and you can see what they did. The only thing I think I stripped out was the docker hub login, for testing purposes I'm just using github's container registry. But here: https://github.com/Starttoaster/ci-playground |
with: | ||
images: | | ||
ghcr.io/${{ github.repository }} | ||
tricksterproxy/trickster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice in Docker Hub, there's a trickstercache user, a tricksterproxy user, and a tricksterio user, that all claim to own the trickster image. Are these all you? Did I even choose the right one in my pull request? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just switched this to trickstercache because I saw that's the user called out in the readme here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is it actually all 3 of them? And if so, is there a reason besides something like a typo-squatting defense?
…ed in readme Signed-off-by: Starttoaster <[email protected]>
Closing. I think there's a lack of interest here. I'm just going to own my fork of this repo with security patches :) |
Sorry for the radio silence on this, I wanted to get to this sooner but I've been extremely busy as of late unfortunately. Eventually carved out time to work on this 😄 Regards #691 FYI @jnichols-git
These workflows should handle building and pushing images to docker hub and github's container registry, using qemu and docker buildx to build for the arm64 and amd64 platforms.
We have two files here:
publish-docker.yaml
::x.x.x
,:x.x
, and:x
), it also updates the:latest
tag from the latest release code, and creates a:sha-<commit sha long>
tag:main
tag, and creates a:sha-<commit sha long>
tagpublish-docker-prerelease.yaml
::x.x.x-rc1
for a tagged prerelease like:x.x.x-rc1
), and creates a:sha-<commit sha long>
tagA slight change here that I wanted to specifically call out was that this adds a new kind of tag that I don't think you currently do. And this is the tag that will get rebuilt over time from a fresh alpine base. Which is the
:main
tag. I can also just switch this to be the:latest
tag, depending on what you want. But:main
gets refreshed every week.:latest
will just track the latest released version and will be refreshed every time a release happens. And the semver tags will just be tagged once when a release is cut.Some important general notes here: