Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle prometheus post query cache correctly #590

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

wu0407
Copy link
Contributor

@wu0407 wu0407 commented Nov 8, 2021

  1. get URL query params from Post request, if no request body then fall back to get URL query params.
  2. Support request content type is application JSON with charset

#587

Signed-off-by: xiaoqing [email protected]

2. Support request content type is application JSON with charset

Signed-off-by: xiaoqing <[email protected]>
@wu0407
Copy link
Contributor Author

wu0407 commented Nov 8, 2021

@jranson @crandles

Signed-off-by: James Ranson <[email protected]>
@jranson jranson requested a review from jnichols-git December 3, 2023 00:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7073583450

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 92.275%

Files with Coverage Reduction New Missed Lines %
pkg/proxy/params/params.go 10 73.33%
Totals Coverage Status
Change from base Build 7073416636: -0.06%
Covered Lines: 17284
Relevant Lines: 18731

💛 - Coveralls

@jranson jranson merged commit fef86de into trickstercache:main Dec 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants