Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix health endpoint HTTP 431 bug (#531) #532

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

tminor
Copy link
Contributor

@tminor tminor commented Feb 3, 2021

No description provided.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2021

CLA assistant check
All committers have signed the CLA.

@tminor tminor closed this Feb 4, 2021
@tminor tminor reopened this Feb 4, 2021
@jranson
Copy link
Member

jranson commented Feb 4, 2021

@tminor Thanks for this great analysis and root causing, and putting in the fix. We really appreciate the time and contribution. This PR will fix up main which is the nextgen codebase, so will not make it out to the masses immediately. The stable branch is v1.1.x, so I will backport this fix and cut a release today. The good news on your question about doing the health check differently in InfluxDB versus the other providers is that I am working on a unified healthcheck package that will eliminate the backend providers needing to implement this handler. Separately, I will add calls to the health check URLs as part of our load test harness, so that we'll be able to catch any issues with calls to health check endpoints in the future.

@jranson jranson merged commit 48a8b6d into trickstercache:main Feb 4, 2021
@jranson jranson mentioned this pull request Feb 4, 2021
@tminor
Copy link
Contributor Author

tminor commented Feb 4, 2021

Fantastic! Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants