fix nil resp panic & deadlock #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimitlessEarth
approved these changes
Jun 3, 2020
jranson
pushed a commit
that referenced
this pull request
Jun 4, 2020
* fix nil resp panic, deadlock on cache marshal err (#453) * additional http post support for prometheus and influxdb (#454) * use methods bitmap when possible for performance * relocate query param funcs to params pkg * use Reader instead of Buffer for read-only bodies * use correct super struct for http/2 compatibility * replace static test certificates with generator * ignore orphaned test cert artifacts * disable failing test (`TestDeltaProxyCacheRequestRemoveStaleLRU`) w/ timeline for permanent fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch ensures that Trickster will not panic when an upstream Fast Forward Request fails and returns a nil response, and ensures that if the cache object fails marshaling for some reason, the cache record is not deadlocked. #452