Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-3448 Fix msys2 expired links #11

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

briv
Copy link

@briv briv commented Nov 21, 2023

DEV-3448 Fix Windows CI builds

Due to the msvc compiler change in microsoft/STL#3818,
the aws-sdk-cpp CI build breaks (warnings are treated as errors).

A fix is available upstream when we upgrade our vcpkg ports but to avoid
an immediate upgrade, we'll define _SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING
for now.
Remove obsolete iOS and zlib patches.
@briv briv requested review from hptrice and nspence November 21, 2023 20:15
Copy link

@nspence nspence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I hope many of these changes were automatic!

@briv
Copy link
Author

briv commented Nov 22, 2023

Oh yeah =) 2f12e69 and 6024ab1 are leaning on git restore --source=upstream/master big time.

@briv briv merged commit f845f47 into trice-develop Nov 22, 2023
@briv briv deleted the DEV-3448/fix-msys2-expired-links branch November 22, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants