Chore - Add next 12 as peer dependency #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
w3bdesign
approved these changes
Aug 12, 2022
|
Is there an update on when this would be merged or any further feedback? Let me know 🙏 |
|
Just a nudge on this one, we'd like to use |
|
Is this going to work for Next13? |
|
You're quite right! It will not... In principle, the code should work correctly in Next.js 13 but you won't be able to install it properly unless it is added here as a peer dependency 😢 |
trezy
approved these changes
Dec 4, 2022
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the bug described in this issue: #39.
This should require no changes to how the module works but will simply allow it to be installed for users already on Next.js 12.
Let me know if this makes sense or whether a more in-depth explanation is needed🙏