[python] build_tx tool: fix amount inaccuracy by parsing with Decimal #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
approved these changes
Sep 13, 2020
|
yes, this should have been there from the start. thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Input amount" was being parsed and displayed incorrectly sometimes while the user was entering the previous outputs to spend.
Also, amount values in the generated bin_outputs of the prev_txes were incorrect sometimes.
Only some amounts were wrong, and each time that I witnessed this, the values were off by one in the least significant digit.
This fix of parsing the amounts with the Decimal class fixed all the problems that I encountered.