Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typescript def. file. #2

Closed
wants to merge 1 commit into from
Closed

Conversation

soerenbf
Copy link
Contributor

Using the library in a typescript react project, and would love simple typings to expose the intended use of the components.

@trevorr
Copy link
Owner

trevorr commented Sep 16, 2019

Thanks for suggesting this. I needed to make some style changes from your PR, but I've included TS definitions in the latest release, 1.0.2.

@trevorr trevorr closed this Sep 16, 2019
@DonGissel
Copy link

Since PR #2 and #3 have been closed and not merged, you should probably acknowledge the contributions of the authors elsewhere..? 🤔

@trevorr
Copy link
Owner

trevorr commented Sep 16, 2019

This PR is acknowledged in the commit: de313da

@trevorr
Copy link
Owner

trevorr commented Sep 16, 2019

Also in the README.md:

Thanks to Anders Gissel for suggesting a fix for IE 11 window scrolling and Søren Bruus Frank for submitting TypeScript definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants