Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shinyAce #62

Merged
merged 4 commits into from
Jun 27, 2019
Merged

Refactor shinyAce #62

merged 4 commits into from
Jun 27, 2019

Commits on Jun 12, 2019

  1. Refactor shinyAce

    -> Rather than building a script and inserting it in the HTML body every time an editor is created,
       we move the element creation logic in the "initialize" step of the shiny widget.
    -> [R] functions (aceEditor, updateAceEditor) create a JSON payload only that is attached to the appropriate element.
    -> Shared Javascript code-path for widget initialization, and widget update (shinyAce.js: updateEditor).
    -> Make JS <-> server.R communication fully module friendly (selectionId, cursorId, hotkeys).  These are all now reported with a prefix "inputId_"
       (similar to shinyAce_hint).  This is a breaking change.
    -> Add couple of examples.
    detule committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    386d67a View commit details
    Browse the repository at this point in the history
  2. tests: RM test-js-quote

    detule committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    ad48ae4 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Configuration menu
    Copy the full SHA
    7ab2d2c View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. autoCompleters: More careful treatment of autoCompleters == ''

    Oliver Gjoneski authored and detule committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    e6eb8e7 View commit details
    Browse the repository at this point in the history