Solution to fix #175: Mute log record emission through Environment Variables #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the function that initially fixes trentm#175 by disabling the record being emitted. Requirements are described in the issue trentm#175. * modified: lib/bunyan.js - Adding a helper method to disable objects by properties * new file: test/log-env-disabled.test.js - Adding the disable test case by setting the environment var before loading the record.
…ect.properties notation This will exercise the case of references using the dot notation for the fix trentm#175. * modified: test/log-env-disabled.test.js - Adding a new env variable - Adding the test case using the object.
marcellodesales
changed the title
trentm
added
needslabels
needstriage
Type-Improvement
Component-Lib
and removed
needslabels
labels
trentm
added a commit
that referenced
this pull request
Feb 3, 2016
|
@marcellodesales My apologies for taking so long to respond (see #335 for While I can see the appeal of this feature, I don't think it belongs in Some philosophy/opinion why I think this doesn't belong in core:
|
|
@trentm The example provided is what I'm looking for... I completely agree that it should be a Stream developed by users! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the function that initially fixes #175 by disabling the
record being emitted. Requirements are described in the issue #175.
the record.