Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.73.0 update #2353

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Rust 1.73.0 update #2353

merged 1 commit into from
Oct 9, 2023

Conversation

Licenser
Copy link
Member

@Licenser Licenser commented Oct 6, 2023

Pull request

Description

Rust 1.73.0 update

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

@Licenser Licenser marked this pull request as ready for review October 6, 2023 13:57
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2353 (d7f65ac) into main (397336c) will decrease coverage by 0.02%.
The diff coverage is 98.64%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   91.01%   91.00%   -0.02%     
==========================================
  Files         275      275              
  Lines       58979    59028      +49     
==========================================
+ Hits        53679    53716      +37     
- Misses       5300     5312      +12     
Flag Coverage Δ
unittests 91.00% <98.64%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/codec/tremor.rs 89.86% <100.00%> (+0.06%) ⬆️
src/connectors/impls/crononome/handler.rs 87.81% <100.00%> (ø)
src/connectors/impls/gcl.rs 96.66% <100.00%> (-0.84%) ⬇️
src/connectors/impls/kafka/consumer.rs 83.45% <ø> (-0.48%) ⬇️
src/connectors/impls/otel/id.rs 98.34% <100.00%> (-0.29%) ⬇️
src/connectors/impls/otel/logs.rs 97.90% <100.00%> (ø)
src/connectors/impls/otel/metrics.rs 97.63% <100.00%> (ø)
src/connectors/impls/otel/trace.rs 100.00% <100.00%> (ø)
src/connectors/source.rs 88.10% <100.00%> (-0.52%) ⬇️
src/connectors/utils/pb.rs 99.66% <ø> (ø)
... and 12 more

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397336c...d7f65ac. Read the comment docs.

mfelsche
mfelsche previously approved these changes Oct 6, 2023
tremor-script/src/errors.rs Show resolved Hide resolved
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser Licenser merged commit c15dda0 into main Oct 9, 2023
18 checks passed
@Licenser Licenser deleted the rust-1.73.0 branch October 9, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants