Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server Highlighting #1

Open
Licenser opened this issue Dec 17, 2019 · 8 comments
Open

Language Server Highlighting #1

Licenser opened this issue Dec 17, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@Licenser
Copy link
Member

This is more a tracking ticket - there is a RFC to integrate highlighting into the language server protocol - if this RFC is accepted we could re-use the highlighting we have in tremor-script instead of having to re-implement it in every editor. That would be a huge win I think.

So I'll drop a link to the upstream Issue on it here: microsoft/language-server-protocol#513

@anupdhml
Copy link
Contributor

yep nice find! I've subscribed to the upstream issue as well.

@Licenser
Copy link
Member Author

Licenser commented Jan 7, 2020

Adding microsoft/vscode-languageserver-node#367 as a link (that's the related PR)

@Licenser
Copy link
Member Author

Licenser commented Jan 7, 2020

gluon-lang/lsp-types#127 is the gluon implementation of it :D

anupdhml added a commit that referenced this issue Feb 7, 2020
Add support for VSCode
@ebkalderon
Copy link
Contributor

ebkalderon commented Mar 4, 2020

Author of tower-lsp here! I think I can implement support for this under a "proposed" feature flag so you could update your language server as well, if you're interested.

EDIT: Opened ebkalderon/tower-lsp#146.

@anupdhml anupdhml added the enhancement New feature or request label May 14, 2020
@ebkalderon
Copy link
Contributor

ebkalderon commented May 20, 2021

We should be getting semantic highlighting support in the next upcoming release of tower-lsp which brings full LSP 3.16 support, including for semantic tokens. 🎉

EDIT: Release 0.14.0 is now out, so it should theoretically be possible to start developing this feature.

@Licenser
Copy link
Member Author

This is really great!!! Thank you so much :)

@ebkalderon
Copy link
Contributor

No worries! I'm sorry for being away for so long. This past year and a half have been pretty happening, to say the least.

@mfelsche
Copy link
Member

No need to be sorry @ebkalderon , it has been hard on all of us. Glad you are still with us and rocking tower-lsp! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants