Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webui - Create A New Repository declares repo ID should be atleast 2 chars but does not allow less than 3 #2967

Closed
itaidavid opened this issue Feb 24, 2022 · 3 comments · Fixed by #3155
Closed

webui - Create A New Repository declares repo ID should be atleast 2 chars but does not allow less than 3 #2967

itaidavid opened this issue Feb 24, 2022 · 3 comments · Fixed by #3155
Assignees
@DataDavD
Labels
area/UI Improvements or additions to UI good first issue Good for newcomers team/versioning-engine Team versioning engine

Comments

@itaidavid
Copy link
Contributor

itaidavid commented Feb 24, 2022 •
edited
Loading

image

The regex at webui/src/lib/components/repositoryCreateForm.jsx, line 18 actually requires 3-63 chars
const repoValidityRegex = /^[a-z0-9][a-z0-9-]{2,62}$/;
while the warning at line 77 states Min 2 characters

Should fix either one
@itaidavid itaidavid added the area/UI Improvements or additions to UI label Feb 24, 2022
@johnnyaug johnnyaug added the good first issue Good for newcomers label Feb 28, 2022
@arielshaqed arielshaqed added the team/versioning-engine Team versioning engine label Mar 16, 2022
@DataDavD
Copy link
Contributor

Hello, not sure if this is assigned to anyone yet, but this seems like a simple enough fix that I can do in my limited spare time this week. Is that fine if I take ownership of this issue?

Thanks in advance

Best,
david

@itaidavid
Copy link
Contributor Author

Hello @DataDavD
You are right and this issue is not assigned on anyone yet.
Not only it is OK if you claim the ownership, it will be highly appreciated.
Please feel free to contact me over this thread, or on our slack if you need any assitance

Thank you 🙏

@DataDavD
Copy link
Contributor

DataDavD commented Mar 28, 2022 •
edited
Loading

@itai-david sounds good. I'll work on it this week. Thank you!

@DataDavD DataDavD mentioned this issue Apr 2, 2022
Merged
DataDavD added a commit to DataDavD/lakeFS that referenced this issue Apr 3, 2022
@DataDavD
Create repo naming should state 3 char min
9390b34 
Currently, there exists a bug upon which the Create A New Repository
form states that repo ID's must be at least 2 characters. However, it
should state that the minimum is 3 characters given S3, Azure Storage,
and Google Cloud Storage all have a 3 character minimum character limit
for bucket naming.

Closes treeverse#2967
nopcoder pushed a commit that referenced this issue Apr 4, 2022
@DataDavD
Create repo naming should state 3 char min (#3155)
bd562b3 
Currently, there exists a bug upon which the Create A New Repository
form states that repo ID's must be at least 2 characters. However, it
should state that the minimum is 3 characters given S3, Azure Storage,
and Google Cloud Storage all have a 3 character minimum character limit
for bucket naming.

Closes #2967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DataDavD DataDavD

Labels
area/UI Improvements or additions to UI good first issue Good for newcomers team/versioning-engine Team versioning engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix create repo min character limit issue DataDavD/lakeFS
4 participants
@johnnyaug @arielshaqed @DataDavD @itaidavid