Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #101 #104

Merged
merged 1 commit into from
May 30, 2023
Merged

fix #101 #104

merged 1 commit into from
May 30, 2023

Conversation

doongjohn
Copy link
Contributor

No description provided.

@guzba
Copy link
Collaborator

guzba commented May 30, 2023

Thanks for the PR. One thought I have is that using [] may be better than {}? I didn't really think about this when originally writing that and now I think perhaps a simple array is a better way to represent that check.

Either way, compiling is and working is better than not compiling though.

@guzba guzba merged commit 7fcad04 into treeform:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doongjohn @guzba