Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix magic errors not causing failure #78

Merged
merged 4 commits into from
Aug 18, 2022
Merged

fix magic errors not causing failure #78

merged 4 commits into from
Aug 18, 2022

Conversation

alex-treebeard
Copy link
Member

#77

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #78 (778d9c5) into main (966edac) will decrease coverage by 1.05%.
The diff coverage is 84.21%.

❗ Current head 778d9c5 differs from pull request most recent head e048648. Consider uploading reports for the commit e048648 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   92.46%   91.41%   -1.06%     
==========================================
  Files           4        4              
  Lines         146      163      +17     
==========================================
+ Hits          135      149      +14     
- Misses         11       14       +3     
Impacted Files Coverage Δ
src/nbmake/pytest_plugin.py 91.30% <80.00%> (-3.44%) ⬇️
src/nbmake/nb_run.py 92.30% <85.71%> (-1.54%) ⬇️

@alex-treebeard alex-treebeard merged commit f0d4475 into main Aug 18, 2022
@alex-treebeard alex-treebeard deleted the fix-magic-bug branch August 18, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant