Exclude APIs that dup given file descriptors from WASI builds #3475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASI doesn't support
dup(2)
system call, so we cannot implement theprint_dot_graph
andprint_dot_graphs
functions with exactly the same semantics as in other platforms.If we really need those functionalities in WASI, we can provide new variants of them that consumes the given fds.
Alternative consideration
If we can accept semantics changes on the fd consumption for those public APIs, we can provide those APIs without adding new variants.