Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opaque type aliases [grammar, highlights, tests] #87

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Jan 6, 2023

Closes #77

As discussed in #85, only adding non-generated code changes to avoid PR chain and conflicts

@eed3si9n
Copy link
Collaborator

eed3si9n commented Jan 6, 2023

Re: non-Linux, this would need #86 first.

Copy link
Collaborator

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM pending CI

@keynmol keynmol force-pushed the opaque-type-alias branch 2 times, most recently from e0cccd5 to 95f67b4 Compare January 7, 2023 07:59
@ckipp01
Copy link
Collaborator

ckipp01 commented Jan 7, 2023

I'm not really sure why, but it seems this is bumping generation time on mac over 20 minutes...

@eed3si9n eed3si9n merged commit 5aa0e55 into tree-sitter:master Jan 7, 2023
@keynmol keynmol deleted the opaque-type-alias branch January 7, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opaque type alias
3 participants