-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow val def at start of lambda #50
Conversation
@@ -603,7 +612,7 @@ module.exports = grammar({ | |||
$.identifier, | |||
), | |||
'=>', | |||
$.expression, | |||
optional($._block), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is one of two meaningful changes in this PR, the rest is just to make it compile
compilation_unit: $ => repeat($._top_level_definition), | ||
|
||
_definition: $ => choice( | ||
_top_level_definition: $ => choice( | ||
$.package_clause, | ||
$.package_object, | ||
$._definition, | ||
), | ||
|
||
_definition: $ => choice( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the second and final meaningful change in this PR, the rest is just to make it compile
apologies in advance, I never know who to tag to get these PRs reviewed @ckipp01 @stevanmilic @maxbrunsfeld thanks again for the review, and happy tree-sittin' |
Hey @stumash! @maxbrunsfeld is the only one with merge permissions on the repo I believe. |
There's CI failures to fix though before being able to merge this. |
@aryx I added r2c as maintainers of this repository too. |
thx |
so is this PR blocked on getting the windows CI build fixed? the last PR was merged despite the windows CI issue. |
as in @returntocorp? |
The windows failure seems unrelated (I think we have the same issue in a few other tree-sitter repos), so I'll merge this. |
resolves #47