Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow val def at start of lambda #50

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

stumash
Copy link
Contributor

@stumash stumash commented May 22, 2022

resolves #47

@@ -603,7 +612,7 @@ module.exports = grammar({
$.identifier,
),
'=>',
$.expression,
optional($._block),
Copy link
Contributor Author

@stumash stumash May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is one of two meaningful changes in this PR, the rest is just to make it compile

Comment on lines +65 to +73
compilation_unit: $ => repeat($._top_level_definition),

_definition: $ => choice(
_top_level_definition: $ => choice(
$.package_clause,
$.package_object,
$._definition,
),

_definition: $ => choice(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the second and final meaningful change in this PR, the rest is just to make it compile

@stumash
Copy link
Contributor Author

stumash commented May 23, 2022

apologies in advance, I never know who to tag to get these PRs reviewed

@ckipp01 @stevanmilic @maxbrunsfeld

thanks again for the review, and happy tree-sittin'

@ckipp01
Copy link
Collaborator

ckipp01 commented May 23, 2022

apologies in advance, I never know who to tag to get these PRs reviewed

Hey @stumash! @maxbrunsfeld is the only one with merge permissions on the repo I believe.

@aryx
Copy link
Contributor

aryx commented May 23, 2022

There's CI failures to fix though before being able to merge this.

@maxbrunsfeld
Copy link
Contributor

@aryx I added r2c as maintainers of this repository too.

@aryx
Copy link
Contributor

aryx commented May 23, 2022

thx

@stumash
Copy link
Contributor Author

stumash commented May 27, 2022

so is this PR blocked on getting the windows CI build fixed? the last PR was merged despite the windows CI issue.

@sideeffffect
Copy link
Contributor

I added r2c as maintainers of this repository too.

as in @returntocorp?

@aryx
Copy link
Contributor

aryx commented Jun 6, 2022

The windows failure seems unrelated (I think we have the same issue in a few other tree-sitter repos), so I'll merge this.

@aryx aryx merged commit 140c96c into tree-sitter:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

val declaration parsed as postfix expression at start of anonymous lambda
5 participants