Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations on enums #248

Merged
merged 1 commit into from
May 28, 2023
Merged

Annotations on enums #248

merged 1 commit into from
May 28, 2023

Conversation

susliko
Copy link
Collaborator

@susliko susliko commented May 27, 2023 •
edited
Loading

Fixes #201

Problem

Annotations on Scala 3 enums and their cases are not supported, e.g.

@A enum E:
  @A("") @B case A

Solution

Allow annotations in enum definitions

eed3si9n
eed3si9n reviewed May 27, 2023
View reviewed changes
grammar.js Outdated Show resolved Hide resolved
@susliko susliko force-pushed the annotations-on-enums branch 4 times, most recently from f140217 to 63493b2 Compare May 27, 2023 23:43
@susliko
Annotations on enums
63493b2 
Problem
-------
Annotations on Scala 3 enums and their cases are not supported, e.g.
```scala
@A enum E:
  @A("") @b case A

```

Solution
-------
Allow annotations in enum definitions
eed3si9n
eed3si9n approved these changes May 28, 2023
View reviewed changes
Copy link
Collaborator

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏!

@eed3si9n eed3si9n merged commit 4072a37 into tree-sitter:master May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotations on enums
2 participants
@susliko @eed3si9n