Allow quotes to be last characters of multi-line string #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susliko
force-pushed
the
better-multiline-strings
branch
from
b363fa9
to
b62f9e1
Compare
eed3si9n
reviewed
May 26, 2023
eed3si9n
approved these changes
May 26, 2023
susliko
force-pushed
the
better-multiline-strings
branch
from
b62f9e1
to
feefa06
Compare
Problem ------- Strings like `"""""""` are valid in scala, but not in the grammar Solution ------- In `scanner.c` emit multi-line string only when at least 3 closing quotes found and the next lookahead is not a quote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225
Problem
Strings like
"""""""are valid in scala, but not in the grammarSolution
In
scanner.cemit multi-line string only when at least 3 closing quotes found and the next lookahead is not a quoteAlso, corpus/literals.txt was formatted with
tree-sitter test -u