Add in support for boolean, character, and symbol literals. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
force-pushed
the
boolean-literals
branch
from
4b5dea8
to
361cff2
Compare
ckipp01
changed the title
ckipp01
changed the title
|
Just realized I also need to support symbol literals as well, plus there is an issue here with character literals. I'll add symbol literals to this as well before marking it ready to review. |
Previously we would just handle boolean literals and character literals as identifiers, and wouldn't handle symbol literals.
ckipp01
force-pushed
the
boolean-literals
branch
from
361cff2
to
b4b6825
Compare
ckipp01
changed the title
ckipp01
commented
Mar 22, 2021
Comment on lines
+651
to
+663
| character_literal: $ => token(seq( | ||
| '\'', | ||
| optional(choice( | ||
| seq('\\', choice( | ||
| /[^xu]/, | ||
| /u[0-9a-fA-F]{4}/, | ||
| /u{[0-9a-fA-F]+}/, | ||
| /x[0-9a-fA-F]{2}/ | ||
| )), | ||
| /[^\\'\n]/ | ||
| )), | ||
| '\'' | ||
| )), |
There was a problem hiding this comment.
I went back and forth on this a bunch trying to exactly get what is described here, and finally I just went with a modified version of what tree-sitter-rust was using.
|
Thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would just handle boolean literals and character literals
as identifiers, and wouldn't handle symbol literals.