Enhance/fix string interpolation model #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
commented
Mar 12, 2021
|
|
||
| val string2 = "$a" | ||
| val string2 = f"hi $name%s" |
There was a problem hiding this comment.
One future thing we can enhance even further here is identifying the formatters as identifiers, but for now there are a ton of other things that are probably more important to tackle than fine graining this.
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr changes and enhances a bit of the way that string interpolation in modeled. Closes #14
Naming change
string_transform_expression->interpolated_string_expressionBehavioral changes
Previously interpolated strings were anything that contained a
$(identifier)or${identifier}where now it must be aseqofidentifierand followed by a string.Previously in
interpolate_string_expressions the string was just astring. We now make a small distinction and thestringinside of theinterpolated_string_expressionis ainterpolated_stringjust to bring a bit more clarity.