feat: add an explicit interpolator field #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_The problem_ Currently when you come across string interpolation you don't get any special highlighting for the actual interpolator meaning: ```scala ivy"com.lihaoyi::os-lib:0.9.0" ``` I all colored the same. _The Solution_ The pr makes 2 changes. - The `identifier` we use for the interpolator now becomes a field for no reason other than I thought it'd be nice to just give it a name - A hightlight query that captures it and assigns it to `function.call`.
keynmol
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Currently when you come across string interpolation you don't get any
special highlighting for the actual interpolator meaning:
Is all colored the same.
The Solution
The pr makes 2 changes.
identifierwe use for the interpolator now becomes a field forno reason other than I thought it'd be nice to just give it a name
function.call.