Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create an issue template #150

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Conversation

ckipp01
Copy link
Collaborator

@ckipp01 ckipp01 commented Jan 15, 2023

No description provided.

required: true

- type: textarea
id: expectation
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the code sample and the error required, but I figured I'd keep this one optional. Some people may have no idea what it should be, so I don't think we need to force this here. Just getting the actual error sample and code is good.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Often I myself have no idea what I expect, it's usually "something but not that"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and you both.

id: error
attributes:
label: Show the error node
description: Show us the output and where the ERROR node is appearing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to put somewhere instructions on how to obtain this output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I was thinking about putting a section in the contributing docs about obtaining it. Let me create a section in there and add it to #149 and then I'll link it from here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, did that and updated it.

@ckipp01 ckipp01 merged commit 4575296 into tree-sitter:master Jan 15, 2023
@ckipp01 ckipp01 deleted the issue branch January 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants