Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes givens #108

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Fixes givens #108

merged 3 commits into from
Jan 9, 2023

Conversation

eed3si9n
Copy link
Collaborator

@eed3si9n eed3si9n commented Jan 9, 2023

This is on top of #106

Problem

Current grammar doesn't handle a common givens pattern:

given Context = ctx

Solution

This fixes it by denoting name etc optional.

eed3si9n and others added 3 commits January 8, 2023 23:57
Problem
-------
Current grammar doesn't handle a common givens pattern:

```
given Context = ctx
```

Solution
--------
This fixes it by denoting name etc optional.
Copy link
Collaborator

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM!

@ckipp01 ckipp01 merged commit 5be2f3a into tree-sitter:master Jan 9, 2023
@eed3si9n eed3si9n deleted the wip/givens_fix branch January 9, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants