Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment node that contains plain comments content #231

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrnossiom
Copy link

@mrnossiom mrnossiom commented Aug 31, 2024

Hi 👋🏻,

I'm working on https://github.com/mrnossiom/lspelling that use TS to extract strings and identifiers from source code to spellcheck them. The grammar works fine to extract doc_comments content, string literals content.

This PR adds a comment field on line_comment and block_comment that contain a comment node with the comment content. It enables easy access to comment content without having to do node matching and strip comment markers based on the node type.

This change matches other parts of the grammar, like string_content or doc_comment.
Names for both the node and the field feel a bit too generic to me. Maybe node: comment_content and content?

I intend to propose such a change on other grammars as well. I was wondering if such a change would have a significant perf impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant