Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for explicit octal integer literal notation #87

Conversation

cfroystad
Copy link
Collaborator

@cfroystad cfroystad commented Jun 19, 2021

Adds support for explicit octal integer literal notation introduced in PHP 8.1.

rfc

This is a minor change, making it possible to explicitly use octal notation by using 0o or 0O ([digit: zero][letter: o case-insensitive])

This change is not relevant for the work on strings, due the the RFC clearly stating:

This RFC has no impact on the behaviour of numeric strings. “0o16” would still be interpreted as a string and only a string. Moreover, (int) "0o16" will continue to evaluate to 0.

Checklist:

  • All tests pass in CI
  • There are sufficient tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (0 rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: 2110, PR: 2110)

@cfroystad cfroystad mentioned this pull request Jun 19, 2021
32 tasks
@cfroystad cfroystad merged commit 612bea7 into tree-sitter:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant