set _POSIX_C_SOURCE=200112L in CFLAGS #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit _POSIX_C_SOURCE was defined first in <stdlib.h> which is included by cgo first[1]. By default <stdlib.h> sets _POSIX_C_SOURCE=199506L, which conflicts with tree-sitter's setting of _POSIX_C_SOURCE=200112L. After this commit we use a CFLAG to set the feature macro before any files are included. [1]: golang/go#35315 Fixes: tree-sitter#7
|
Hm this is an unideal solution but totally fine (go moment) - I noticed this in a machine of mine as well but chalked it up to a bad environment or something since GH's Linux CI machines were happy anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit _POSIX_C_SOURCE was defined first in <stdlib.h> which is included by cgo first1. By default <stdlib.h> sets _POSIX_C_SOURCE=199506L, which conflicts with tree-sitter's setting of _POSIX_C_SOURCE=200112L. After this commit we use a CFLAG to set the feature macro before any files are included.
Fixes: #7